[Core] Multi-tenancy: Reject worker registration if job has finished #10569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfstorm
changed the title
…istration_if_job_is_finished
ericl
approved these changes
Sep 9, 2020
ericl
added
the
@author-action-required
raulchen
approved these changes
Sep 14, 2020
kfstorm
removed
the
@author-action-required
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
If a worker process is spawned before the job finishes but is registered after the job finishes, we shouldn't allow it to be registered. Otherwise, it will never be killed.
Related issue number
Checks
scripts/format.shto lint the changes in this PR.