-
Notifications
You must be signed in to change notification settings - Fork 6.2k
End-to-end object size information passthrough #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
atumanov
commented
Dec 9, 2016
- pass through object size information from Plasma store to Plasma manager to Redis.
- a separate hash table struct is created for storing object attribute information.
- object attribute table subscribe methods for schedulers to listen to object information.
- separate subscribe methods for object keyspace notifications and object attribute pub/sub channel.
supersedes #90 |
pcmoritz
reviewed
Dec 9, 2016
void subscribe_success_objectinfo_available_callback(object_id object_id, | ||
int64_t object_size, | ||
void *user_context) { | ||
printf("[object avail] XXXreceived object size = %d XXX\n", object_size); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this print
time_left -= 0.2 | ||
time.sleep(0.2) | ||
|
||
print("time waiting for plasma manager to fail = %.2f" % (10-time_left)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
print("Time waiting for plasma manager to fail = {:.2}".format(10 - time_left))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.