Skip to content

[rllib] Train script overwrites framework field in experiment config argument #9568

Closed
@konradkalita

Description

@konradkalita

[rllib]

What is the problem?

Framework setting passed to training script via config argument is ignored, because training script uses separate arguments for this field (--torch, --eager). If none of these args is passed to the script the framework is set to tf, regardless of options passed in --config argument.

Expected behavior

Script should use default value for framework field only if it is not already present in config dict (it can be passed as cmd argument or be loaded from file).

Reproduction (REQUIRED)

Run rllib train --run DQN --env CartPole-v0 --config "{\"framework\": \"tfe\"}" - script uses tf instead of tfe

  • I have verified my script runs in a clean environment and reproduces the issue.
  • I have verified the issue also occurs with the latest wheels.

Metadata

Metadata

Assignees

Labels

P2Important issue, but not time-criticalbugSomething that is supposed to be working; but isn'ttriageNeeds triage (eg: priority, bug/not-bug, and owning component)

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions