Skip to content

Fatal logging statements in plasma store no longer print backtraces. #672

Closed
@robertnishihara

Description

@robertnishihara

The plasma store recently switched from the LOG_FATAL macro to ARROW_FATAL. The change was done in #579.

The LOG_FATAL macro: https://github.com/ray-project/ray/blob/master/src/common/common.h#L91

ARROW_LOG(FATAL) is implemented here https://github.com/ray-project/ray/blob/master/src/plasma/logging.h#L95.

Some differences, which we may want to address.

  • LOG_FATAL prints a backtrace, which makes debugging easier.
  • LOG_FATAL exits with abort() (as opposed to exit()) so as to produce a core dump.
  • LOG_FATAL prints the word FATAL in the logging message, which makes the log file easier to read/search.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions