Skip to content

[Core] Handle transient network error for pushing object chunks #50803

Open
@jjyao

Description

What happened + What you expected to happen

void ObjectManager::HandleSendFinished(const ObjectID &object_id,
                                       const NodeID &node_id,
                                       uint64_t chunk_index,
                                       double start_time,
                                       double end_time,
                                       ray::Status status) {
  RAY_LOG(DEBUG).WithField(object_id)
      << "HandleSendFinished on " << self_node_id_ << " to " << node_id
      << " of object, chunk " << chunk_index << ", status: " << status.ToString();
  if (!status.ok()) {
    // TODO(rkn): What do we want to do if the send failed?
    RAY_LOG(DEBUG).WithField(object_id).WithField(node_id)
        << "Failed to send a push request for an object to node. Chunk index: "
        << chunk_index;
  }
}

We should fix this TODO using retryable_grpc_client

Versions / Dependencies

master

Reproduction script

N/A

Issue Severity

None

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    P1Issue that should be fixed within a few weeksbugSomething that is supposed to be working; but isn'tcoreIssues that should be addressed in Ray Corecore-object-store

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions