Skip to content

[core] Inconsistent timestamp handling #48760

Closed
@rynewang

Description

@rynewang

What happened + What you expected to happen

gcs::CreateErrorTableData takes a double timestamp.

Here it takes milliseconds from std clock:

gcs::CreateErrorTableData("task", error_message, current_time_ms(), job_id);

Here it takes nanoseconds from absl:

absl::GetCurrentTimeNanos(),

We need to:

  1. figure out it takes ms or ns
  2. fix by changing arg to absl::Time

Versions / Dependencies

master

Reproduction script

Issue Severity

Medium: It is a significant difficulty but I can work around it.

Metadata

Metadata

Assignees

Labels

P2Important issue, but not time-criticalbugSomething that is supposed to be working; but isn'tcoreIssues that should be addressed in Ray Core

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions