-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Closed
Labels
P2Important issue, but not time-criticalImportant issue, but not time-criticalbugSomething that is supposed to be working; but isn'tSomething that is supposed to be working; but isn'tcommunity-backlogcoreIssues that should be addressed in Ray CoreIssues that should be addressed in Ray Core
Description
What happened + What you expected to happen
gcs::CreateErrorTableData
takes a double timestamp
.
Here it takes milliseconds from std clock:
ray/src/ray/raylet/node_manager.cc
Line 2177 in d4e2660
gcs::CreateErrorTableData("task", error_message, current_time_ms(), job_id); |
Here it takes nanoseconds from absl:
absl::GetCurrentTimeNanos(), |
We need to:
- figure out it takes ms or ns
- fix by changing arg to absl::Time
Versions / Dependencies
master
Reproduction script
Issue Severity
Medium: It is a significant difficulty but I can work around it.
Metadata
Metadata
Assignees
Labels
P2Important issue, but not time-criticalImportant issue, but not time-criticalbugSomething that is supposed to be working; but isn'tSomething that is supposed to be working; but isn'tcommunity-backlogcoreIssues that should be addressed in Ray CoreIssues that should be addressed in Ray Core