Ray depends on pytest in setup.py

[devin-petersohn]

System information

• OS Platform and Distribution (e.g., Linux Ubuntu 16.04): WSL
• Ray installed from (source or binary): pip
• Ray version: 0.6.1
• Python version: 3.6
• Exact command to reproduce: pip install ray

Describe the problem

I don't think we need to be depending on pytest for the library itself. If travis needs pytest, we can just install it in install_dependencies script. Is there a particular reason that ray depends on pytest always?

Source code / logs

N/A

[robertnishihara]

I guess one option is to put it in tests_require, e.g.,

https://github.com/apache/arrow/blob/54b35b4c13a8904286eca80bb76d9f4e7b619a87/python/setup.py#L556-L557

[devin-petersohn]

Is it a jenkins issue? We have a requirements.txt in Modin that includes all the testing requirements.

[richardliaw]

We should just put it in .travis.yml and requirements.txt for jenkins, right?

…

On Fri, Jan 11, 2019 at 12:07 PM Devin Petersohn ***@***.***> wrote: Is it a jenkins issue? We have a requirements.txt in Modin that includes all the testing requirements. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3751 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEUc5T-sRW1T2y2IrUhtjA6pQYdfWZU8ks5vCO7lgaJpZM4Z8F22> .

[robertnishihara]

It should be in the setup.py because the tests depend on it. If not install_requires then at least tests_require.

We don't have a requirements.txt.

Out of curiosity, what is the issue with the current approach?

[devin-petersohn]

In the spirit of python, we should only install what is necessary for the users' environments as install_requires. More specifically for me, Modin tests rely on a specific version of pytest, and this overwrites it every time. I think it should be in tests_require as it is not a dependency of Ray itself.

[olivierlefloch]

Would it be possible to move pytest out of the installation requirements (tests_require would be fine)? I don't want to install it in the code I deploy, but ray requires it as things stand.

[robertnishihara]

I agree with that. It should only be necessary for the tests.