Skip to content

Update kai_scheduler.go to support all types #4418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
enoodle wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update kai_scheduler.go to support all types #4418

enoodle wants to merge 3 commits into from
+50 −7

Conversation

@enoodle
Copy link

@enoodle enoodle commented Jan 20, 2026 •
edited
Loading

Why are these changes needed?

KAI actually supports all types of Ray Jobs / Clusters, this limitation is not needed.

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

win5923
win5923 reviewed Jan 20, 2026
View reviewed changes
Copy link
Member

@win5923 win5923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!
Could you share some details on how this was tested, maybe a few screenshots or steps?

@enoodle
Update kai_scheduler.go to support all types
f5e3e8a 
Signed-off-by: Erez Freiberger <enoodle@gmail.com>
@enoodle enoodle force-pushed the erez/kai-scheduler-all-types-support branch from a1d4f8b to f5e3e8a Compare January 20, 2026 18:49
@enoodle
Copy link
Author

enoodle commented Jan 20, 2026 •
edited
Loading

@win5923 I created a kind cluster with KAI and ray with this guide https://docs.ray.io/en/latest/cluster/kubernetes/k8s-ecosystem/kai-scheduler.html I added the flag --set batchScheduler.name=kai-scheduler. Then I tried to submit a RayJob (This sample from the ray docs) and failed - the operator didn't create any pods and I saw an error in the logs. So I built with this change and switched the images and then I could create the RayJob and the pods were scheduled by KAI-Scheduler.

@enoodle
Copy link
Author

enoodle commented Jan 20, 2026

I updated the PR to fix the formatting errors that left some unused imports.

@enoodle
Copy link
Author

enoodle commented Jan 20, 2026

@win5923 Now also added unit test in kai_scheduler_test.go for RayJob.

@enoodle enoodle requested a review from win5923 January 21, 2026 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevin85421 kevin85421 Awaiting requested review from kevin85421 kevin85421 is a code owner

@andrewsykim andrewsykim Awaiting requested review from andrewsykim andrewsykim is a code owner

@rueian rueian Awaiting requested review from rueian rueian is a code owner

@MortalHappiness MortalHappiness Awaiting requested review from MortalHappiness MortalHappiness is a code owner

@win5923 win5923 Awaiting requested review from win5923

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@enoodle @win5923