[historyserver][collector] use filepath functions to handle file path #4417
+13
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 400Ping <jiekai.chang326@gmail.com>
| return s3Client | ||
| } | ||
|
|
||
| func startMinioPortForward(test Test, g *WithT) string { |
Contributor
There was a problem hiding this comment.
Seems out of scope for this PR. I think it would be better to open another issue to track the flaky part of the collector tests. Thanks.
Btw, I'm thinking whether to switch to another issue to resolve the path issue at once here. If you're interested, you can take a look.
400Ping
force-pushed
the
historyserver/filepath-func
branch
from
fc48fc8 to
d8c6b82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
There are some hardcode path in historyserver collector. We can use filepath to provide cross-platform capabilities for those filename paths.
For example,
r.prevLogsDir = "/tmp/ray/prev-logs"->r.prevLogsDir = filepath.Join("tmp", "ray", "prev-logs")Related issue number
Closes #4393
Checks