[WIP][Fix][RayJob SidecarMode] Prevent premature job termination during transient head node spikes #4399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: justinyeh1995 <justinyeh1995@gmail.com>
justinyeh1995
changed the title
Member
Future-Outlier
left a comment
Future-Outlier
left a comment
There was a problem hiding this comment.
- we should make sure this only be used when k8s version >= 1.34
- we should also have some mechanism to check user open the alpha feature via feature gate.
Contributor
Author
Appreciate the concrete suggestions. I am wondering whether we should keep the current fix (checking dashboard before applying timeout) as a fallback for users with k8s version < 1.34. Or should we simply focus on solving it for k8s version >= 1.34. My judgement is these two can co-exist. |
Contributor
Author
|
After discussing offline with @Future-Outlier, this pr will instead focus on implementing restarting submitter for k8s version 1.34+. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The submitter sidecar may exit during transient head‑node spikes.
For Kubernetes versions under 1.34, this change makes SidecarMode treat the Ray dashboard job status as the source of truth and avoids failing a RayJob just because the submitter sidecar exits. It defers failure decisions until after GetJobInfo to prevent premature termination during transient head‑node spikes, while still tracking the submitter’s finished time for a final fallback.
For Kubernetes v1.34+, we can restart the submitter. This part is still under construction.
Related issue number
Closes #4285
Checks