[history server][collector] Migrate to new AWS S3 SDK version #4369
+419
−245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 400Ping <fourhundredping@gmail.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Signed-off-by: Ping <fourhundredping@gmail.com>
Signed-off-by: 400Ping <fourhundredping@gmail.com>
Signed-off-by: 400Ping <fourhundredping@gmail.com>
400Ping
force-pushed
the
feature/migrate-to-new-AWS-S3-SDK
branch
from
8cf62f2 to
b80d431
Compare
400Ping
force-pushed
the
feature/migrate-to-new-AWS-S3-SDK
branch
from
cbae15b to
80be943
Compare
400Ping
force-pushed
the
feature/migrate-to-new-AWS-S3-SDK
branch
from
ceaefd0 to
9e3c1e4
Compare
Signed-off-by: Jie-Kai Chang <jiekai.chang326@gmail.com>
Signed-off-by: 400Ping <jiekai.chang326@gmail.com>
Signed-off-by: 400Ping <jiekai.chang326@gmail.com>
Member
Future-Outlier
left a comment
Future-Outlier
left a comment
There was a problem hiding this comment.
Hi, @400Ping
do you mind solve the merge conflict? thank you!
also cc @fsNick @win5923 @JiangJiaWei1103 for review
Signed-off-by: Jie-Kai Chang <jiekai.chang326@gmail.com>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Comment on lines
378
to
380
| PartitionID: "aws", | ||
| URL: endpoint, | ||
| SigningRegion: "us-east-1", |
Contributor
There was a problem hiding this comment.
Thanks for contributing! Would you mind defining the partition and the region as constants so they can be reused?
For example:
config.WithRegion("us-east-1"),here can be modified to:
config.WithRegion(s3Region),
Signed-off-by: 400Ping <jiekai.chang326@gmail.com>
Signed-off-by: 400Ping <jiekai.chang326@gmail.com>
win5923
reviewed
Jan 20, 2026
historyserver/pkg/storage/s3/s3.go
Outdated
| awsconfig.WithHTTPClient(httpClient), | ||
| } | ||
| if endpoint != "" { | ||
| resolver := aws.EndpointResolverWithOptionsFunc( |
Member
There was a problem hiding this comment.
aws.EndpointResolverWithOptionsFunc is deprecated.
Contributor
Author
There was a problem hiding this comment.
Thanks for the catch, updated in e0962df
Signed-off-by: 400Ping <jiekai.chang326@gmail.com>
Signed-off-by: Jie-Kai Chang <jiekai.chang326@gmail.com>
Signed-off-by: 400Ping <jiekai.chang326@gmail.com>
Signed-off-by: 400Ping <jiekai.chang326@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Summary
Migrates the historyserver S3 client from AWS SDK v1 to v2, covering client initialization, error handling, pagination, and MinIO path‑style behavior, plus updates the e2e tests and module dependencies.
Changes
s3.go: switch to v2 config/client, paginator, and smithy error handling; keep bucket auto‑create and MinIO path‑style.config.go: remove v1 aws.Bool usage; use bool + parsing helpers.collector_test.go: update e2e S3 client/paginator/types to v2.Related issue number
Closes #4280
Checks