Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix][kubectl-plugin] Create separate namespaces for each kubectl plugin e2e test #2745

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

MortalHappiness
Copy link
Member

@MortalHappiness MortalHappiness commented Jan 14, 2025

Why are these changes needed?

I found that the kubectl plugin e2e tests failed because they interfered with each other.

This PR attempts to fix the kubectl plugin e2e errors by creating separate test namespaces for each test.

Skipped one test because it still fails.

Related issue number

Closes: #2729

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@MortalHappiness MortalHappiness force-pushed the bugfix/#2729-testkubectlraycommand-fail branch from 48ab32a to bd055a2 Compare January 14, 2025 11:08
@MortalHappiness MortalHappiness marked this pull request as ready for review January 14, 2025 11:08
@MortalHappiness MortalHappiness force-pushed the bugfix/#2729-testkubectlraycommand-fail branch 2 times, most recently from 00c9e96 to 4589c96 Compare January 14, 2025 11:16
…gin e2e test

Closes: ray-project#2729
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
@MortalHappiness MortalHappiness force-pushed the bugfix/#2729-testkubectlraycommand-fail branch from 4589c96 to d7a2d9d Compare January 14, 2025 11:17
@MortalHappiness MortalHappiness marked this pull request as draft January 14, 2025 12:17
…ost"

Closes: ray-project#2729
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
@MortalHappiness MortalHappiness force-pushed the bugfix/#2729-testkubectlraycommand-fail branch from dbe3a90 to 9fbcbc8 Compare January 14, 2025 12:19
Closes: ray-project#2729
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] TestKubectlRayCommand fail
1 participant