Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor][Kubectl-plugin] Replace dynamic client with Ray client #2703

Conversation

MortalHappiness
Copy link
Member

@MortalHappiness MortalHappiness commented Dec 31, 2024

Why are these changes needed?

See the description in the corresponding issue for details.

This PR replaces all Unstructured and DynamicClient objects in kubectl-plugin with native KubeRay types.

Related issue number

Closes: #2386

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@MortalHappiness
Copy link
Member Author

MortalHappiness commented Dec 31, 2024

@chiayi @andrewsykim PTAL

Copy link
Contributor

@chiayi chiayi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one small nit

kubectl-plugin/pkg/cmd/get/get_cluster_test.go Outdated Show resolved Hide resolved
Closes: ray-project#2386
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
Closes: ray-project#2386
Signed-off-by: Chi-Sheng Liu <chishengliu@chishengliu.com>
@MortalHappiness MortalHappiness force-pushed the feature/#2386-kubectl-import-operator branch from 745a7de to 91ef955 Compare January 6, 2025 03:56
@kevin85421
Copy link
Member

stamp

@kevin85421 kevin85421 merged commit 9a48b82 into ray-project:master Jan 9, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Proposal] Let kubectl-plugin import KubeRay types from ray-operator
4 participants