-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support node selector in the API server #2523
base: master
Are you sure you want to change the base?
Conversation
if len(template.NodeSelector) != 0 { | ||
t.Errorf("failed to convert config map, expected no node selector, got %d", len(template.NodeSelector)) | ||
} | ||
if len(template.NodeSelector) != 0 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
can you rebase with the master branch? I just fixed a CI issue. |
ddf9f8c
to
0b75d64
Compare
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
Created the a RayCluster and verified pods are deployed to the ray-test-worker2
cd apiserver && KIND_CLUSTER_NAME=ray-test make cluster
helm install kuberay-operator kuberay/kuberay-operator --version 1.2.2
make run
# Create a template with nodeselector
curl -X 'POST' 'http://localhost:8888/apis/v1/namespaces/default/compute_templates' -H 'accept: application/json' -H 'Content-Type: application/json' -d '{
"name": "default-template",
"namespace": "default",
"cpu": "2",
"memory": "2",
"nodeSelector": {
"kubernetes.io/hostname": "ray-test-worker2"
}
}'
curl -X 'POST' \
'http://localhost:8888/apis/v1/namespaces/default/clusters' \
-H 'accept: application/json' \
-H 'Content-Type: application/json' \
-d '{
"name": "test-cluster",
"namespace": "default",
"user": "tedchang",
"version": "2.9.0",
"environment": "DEV",
"clusterSpec": {
"headGroupSpec": {
"computeTemplate": "default-template",
"image": "rayproject/ray:2.9.0",
"serviceType": "NodePort",
"rayStartParams": {"dashboard-host": "0.0.0.0"}
},
"workerGroupSpec": [
{
"groupName": "small-wg",
"computeTemplate": "default-template",
"image": "rayproject/ray:2.9.0",
"replicas": 1,
"minReplicas": 0,
"maxReplicas": 1,
"rayStartParams": {"metrics-export-port": "8080"}
}
]
}
}'
Should see something:
# kubectl get po -owide
NAME READY STATUS RESTARTS AGE IP NODE NOMINATED NODE READINESS GATES
kuberay-operator-79bb76fc8-lp9bv 1/1 Running 0 4m1s 10.244.3.2 ray-test-worker2 <none> <none>
test-cluster-head-chg9t 1/1 Running 0 2m12s 10.244.3.3 ray-test-worker2 <none> <none>
test-cluster-small-wg-worker-n74s7 1/1 Running 0 2m12s 10.244.3.4 ray-test-worker2 <none> <none>
@kevin85421 can you, please, merge? |
@andrewsykim, @kevin85421 any progress on merging this? |
0b75d64
to
36fb48d
Compare
@kevin85421 what seems to be a holdup? also there is another #2556 that is the same as mine |
@andrewsykim, @kevin85421 it has been 2 weeks with no progress |
@kevin85421, @andrewsykim any chance we can close this before the end of the year? |
Why are these changes needed?
Current version of the API server do not supports node selector, which are very useful for Ray deployment
Related issue number
Checks