REP: KubeRay RayService Incremental Rollout #58
+125
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ryanaoleary <ryanaoleary@google.com>
andrewsykim
reviewed
Dec 20, 2024
| metadata: | ||
| name: example-rayservice | ||
| spec: | ||
| upgradeStrategy: "NewCluster" |
There was a problem hiding this comment.
It's not too late to change this API since it's not released yet, should we change this now before v1.3 so it'll play nicely with the new fields you're proposing here?
spec:
upgradeStrategy:
type: "NewCluster"
targetCapacity: 50
maxSurgePercent: 50
...
There was a problem hiding this comment.
At least for 1.3, we can just support
spec:
upgradeStrategy:
type: NewCluster
So it's easy to add new fields in v1.4 that are compatible with the upgradeStrategy
There was a problem hiding this comment.
Oh yeah I like that idea, I'll edit the REP to reflect that and put out a PR with the API fix.
There was a problem hiding this comment.
a5ea9db, API change: ray-project/kuberay#2678
Signed-off-by: ryanaoleary <ryanaoleary@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add REP for RayService incremental upgrade strategy using
max_surge_percentand Gateway API.