-
-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Https and SIGINT handling #201
base: master
Are you sure you want to change the base?
Conversation
Hello @tetofonta , thank you so much for contributing to remi project. I will see at your pull req in about a week, I'm abroad right now. ;-) |
In order to secure any form inputs, the websocket connection would need to be secured. Using wss:// as the protocol that the javascript part connects to. I have a branch which secures both sockets. Unfortunately in a clumsy way so I never created a PR for it. |
@tetofonta I merged your code to a branch called tetofonta-https. I a near future I will merge it to master, after a bit of debugging. |
@tetofonta Made some tests but without success. I got this error: remi.server INFO Started httpserver https://127.0.0.1:8073/ Does this work for you? Can you give me some advices? |
No idea about what's happened, it works fine for me. |
@tetofonta Done some more testing. It appears that your https fix is ok but REQUIRES wss (secured websocket) to work correctly. This is because unsecure websocket is not allowed under https. |
When using remi on a network can be useful to use https protocol for security reasons: this can be done by calling "ssl.warp_socket(...)" over the HTTPServer created socket.
Also, when developing application, is useful to terminate the process with CTRL+C key, so it can be done by allowing user to specify if SIGINT needs to be ignored.