Skip to content

Commit

Permalink
fix(edit) edit cell scope was not being destroyed when element was re…
Browse files Browse the repository at this point in the history
…moved
  • Loading branch information
swalters committed Jan 24, 2015
1 parent 08a5939 commit 68a22ae
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion src/features/edit/js/gridEdit.js
Original file line number Diff line number Diff line change
Expand Up @@ -406,6 +406,8 @@
var cellModel;
var cancelTouchstartTimeout;

var editCellScope;

registerBeginEditEvents();

function registerBeginEditEvents() {
Expand Down Expand Up @@ -634,7 +636,8 @@
cancelBeginEditEvents();
var cellElement = angular.element(html);
$elm.append(cellElement);
$compile(cellElement)($scope.$new());
editCellScope = $scope.$new();
$compile(cellElement)(editCellScope);
var gridCellContentsEl = angular.element($elm.children()[0]);
isFocusedBeforeEdit = gridCellContentsEl.hasClass('ui-grid-cell-focus');
gridCellContentsEl.addClass('ui-grid-cell-contents-hidden');
Expand Down Expand Up @@ -676,6 +679,7 @@
}
var gridCellContentsEl = angular.element($elm.children()[0]);
//remove edit element
editCellScope.$destroy();
angular.element($elm.children()[1]).remove();
gridCellContentsEl.removeClass('ui-grid-cell-contents-hidden');
if (retainFocus && isFocusedBeforeEdit) {
Expand Down

0 comments on commit 68a22ae

Please sign in to comment.