Multiple minor tickets RDBC (739-749) #191
Merged
Merged
Conversation
…loseableAttachmentResult
poissoncorp
changed the title
poissoncorp
changed the title
… to quad_prefix_tree_index
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RDBC-739 LoaderWithInclude.load should return typed result
RDBC-740 Typehint attachments.store()
RDBC-741 Get attachment method should be typehinted that it returns CloseableAttachmentResult
RDBC-743 Add id_ field to Facet Setup
RDBC-747 FacetBase.to_json doesn't care if there are options or not provided
Breaking changes:
RDBC-742 Method aggregate_by_facets should take facets list as an argument
RDBC-744 Delete unnecessary FacetTermSortMode definition
RDBC-749 Change GeographySpatialOptionsFactory.quad_prefix_tree_level to quad_prefix_tree_index