-
Notifications
You must be signed in to change notification settings - Fork 142
RDoc-3634 Expose Guides in Documentation #2240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Lwiel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Guides landing page has different content width than docs landing page
- Default
Edit on GitHubbutton shouldn't be displayed for guides (currently it's displayed and disabled) - Tags should probably be displayed above the guide content (e.g. in
/guides/example-guide)
- I'm not sure if we want to have next/previous buttons on the bottom of each guide
- Guides navbar button should move the user to guides landing page instead of documentation landing page
6c92630 to
3ecde13
Compare
|
@kalczur It's ready for review |
|
@kalczur all the fixes have been implemented |
| import { Icon } from "./Icon"; | ||
| import { IconName } from "@site/src/typescript/iconName"; | ||
|
|
||
| // eslint-disable-next-line no-undef |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it's not required
# Conflicts: # docusaurus.config.ts # Conflicts: # docusaurus.config.ts
928026b to
ee44b63
Compare
poissoncorp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Before deployment, we need to:
- Add all external articles to our content list
- Introduce 2 guides from @Netzach-Nyss about Remote Attachments and Schema Validation
5f2ab5e to
8e53400
Compare
|
All the external guides have been added. |
No description provided.