Skip to content

fix(rune): Correct build logic for rune module #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −1
Open

fix(rune): Correct build logic for rune module #138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion rune/lib/nx_rune.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,11 @@ type _ Effect.t +=
}
-> (float, Dtype.float64_elt) t Effect.t
| E_psum : { t_in : ('a, 'b) t } -> ('a, 'b) t Effect.t
| E_qr : {
t_in : ('a, 'b) t;
reduced : bool;
}
-> (('a, 'b) t * ('a, 'b) t) Effect.t

(* Native_context creation *)
let create_context () : context = Native_context (Nx_c.create_context ())
Expand Down Expand Up @@ -611,7 +616,16 @@ let op_irfft (type a c) (t : (Complex.t, a) t) ~(dtype : (float, c) Dtype.t)
let op_cholesky ~upper:_ _ =
failwith "op_cholesky: not implemented in Rune backend"

let op_qr ~reduced:_ _ = failwith "op_qr: not implemented in Rune backend"
let op_qr ~reduced t_in =
try Effect.perform (E_qr { t_in; reduced })
with Effect.Unhandled _ -> (
match t_in with
| Native_tensor t ->
let q, r = Nx_c.op_qr ~reduced t in
(Native_tensor q, Native_tensor r)
| Symbolic_tensor _ ->
failwith "op_qr: symbolic tensors not supported in Rune backend")


let op_svd ~full_matrices:_ _ =
failwith "op_svd: not implemented in Rune backend"
Expand Down