fix encoding problem in windows console #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file was save in an UTF8 encoding and (apparently) not converted back to a codepage suitable for the windows command line (codepage 850). This patch makes sure you get the right character independent of the file encoding. Obviously detecting the environment and serving up the right codepage would be nicer, but i recommend to leave this patch in for now until there is a better solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file was save in an UTF8 encoding and (apparently) not converted back to a codepage suitable for the windows command line (codepage 850). This patch makes sure you get the right character independent of the file encoding. Obviously detecting the environment and serving up the right codepage would be nicer, but i recommend to leave this patch in for now until there is a better solution.