Nan values in off-diagonal correlations of flag data points causing division by zero error in robust solver

[ulricharmel]

I just noticed from one of the 3C147 (C-config, average, low bandwidth) that certain visibilities have nan values in their off diagonals (nan+nanj). Although these visibilities are flagged and have zero weights, this computation https://github.com/ratt-ru/CubiCal/blob/master/cubical/solver.py#L497 returns [0, nan+nanj, nan+nanj, 0] for those visibilities. This doesn't seem to have any repercussions on the complex solver but this leads to division by zero error for the robust solver. I don't know if this can be fixed in the data handler when reading the data. A temporary quick fix for now which I have adopted on my local branch is to reset all flagged visibilities to zero. i.e. add a copy of line https://github.com/ratt-ru/CubiCal/blob/master/cubical/solver.py#L502 below https://github.com/ratt-ru/CubiCal/blob/master/cubical/solver.py#L497

Probably a similar thing should be done after line https://github.com/ratt-ru/CubiCal/blob/master/cubical/solver.py#L521 for model visibilities.

[bennahugo]

Which version of casacore are you using? Note that versions <3.2 had a bug in the incremental storage manager that we have since fixed. Compile and install 3.3 locally to ensure this is not the cause of the issue.

…

On Fri, 07 Aug 2020, 19:30 ulricharmel, ***@***.***> wrote: I just noticed from one of the 3C147 (C-config, average, low bandwidth) that certain visibilities have nan values in their off diagonals (nan+nanj). Although these visibilities are flagged and have zero weights, this computation https://github.com/ratt-ru/CubiCal/blob/master/cubical/solver.py#L497 returns [0, nan+nanj, nan+nanj, 0] for those visibilities. This doesn't seem to have any repercussions on the complex solver but this leads to division by zero error for the robust solver. I don't know if this can be fixed in the data handler when reading the data. A temporary quick fix for now which I have adopted on my local branch is to reset all flagged visibilities to zero. i.e. add a copy of line https://github.com/ratt-ru/CubiCal/blob/master/cubical/solver.py#L502 below https://github.com/ratt-ru/CubiCal/blob/master/cubical/solver.py#L497 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#407>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB4RE6WWEX7FDRP23CP7HA3R7Q2ZRANCNFSM4PX3BDFA> .

[ulricharmel]

3.0 I will try 3.3 then