Fixes to SEC1.0 when no DIGITAL wall panel connected #208
Conversation
mitchjs
commented
Jun 27, 2024
mitchjs
commented
- changed transmit of sec1 byte (affected digital wall panel emulation)
- changed rules for packet (command) transmit when in wall panel emulation
- tweaked log to console for wall plate emulation
|
Could you squash the two commits into one, then we can merge into main. Thanks. |
src/comms.cpp
Outdated
| @@ -174,29 +174,31 @@ void wallPlate_Emulation() { | |||
| // wait up to 15 seconds to look for an existing wallplate or it could be booting, so need to wait | |||
| if (currentMillis - serialDetected < 15000 || wallplateBooting == true) { | |||
| if (currentMillis - lastRequestMillis > 1000) { | |||
| Serial.println("Looking for security+ 1.0 wall panel..."); | |||
| Serial.println("Looking for security+ 1.0 DIGITAL wall panel..."); | |||
There was a problem hiding this comment.
These log messages won't log over the network. Should consider using the macros instead.
There was a problem hiding this comment.
yea i know... could change, but it was that way before i touched the code for the sec 1 fix
let me change it, then @dkerr64 figure out how to squash commits :)
tweaked log to console for wall plate emulation changed transmit of sec1 byte changed logging method for wall panel detection changed "ok to send" rules for xmit of commands
|
Is this ready for merge? |
|
Most of the users seem to have Sec+2 and most won't test until there is a new official release published. I'll merge it and do a 1.5.1 build. |
|
ok, i assume you mean 1.6.1 |
|
Yes, 1.6.1. The lift master jackshaft opener appears to use the same wall panel that I have, so this firmware should work with those as well. |
|
I have a small PR I was working on. I'll do a build when I'm done with that. |
