Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test on PHP 8.0, 8.1, and 8.2 #923

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Test on PHP 8.0, 8.1, and 8.2 #923

wants to merge 2 commits into from

Conversation

WyriHaximus
Copy link

No description provided.

@frank9999
Copy link
Contributor

Thanks for this PR! I also wanted to add PHP 8.1 and 8.2 to CI :) I also noticed that PHP 7.2 and higher has pipelines failing. Added an issue #927

@WyriHaximus
Copy link
Author

@frank9999 Just waiting for Chris to finish the RFC package before he looks at this. Already had a chat with him about this in private.

@cboden cboden changed the base branch from master to v0.4.4 December 12, 2021 16:58
@cboden
Copy link
Member

cboden commented Dec 12, 2021 •
edited
Loading

Can you rebase your branch please? This should fix the failing tests.

@cboden cboden modified the milestone: 0.4.4 Dec 12, 2021
@cboden cboden deleted the branch ratchetphp:master December 14, 2021 00:14
@cboden cboden closed this Dec 14, 2021
@cboden cboden reopened this Dec 14, 2021
@cboden cboden changed the base branch from v0.4.4 to master December 14, 2021 00:22
@WyriHaximus
Copy link
Author

@cboden Just rebased and push force with lease

@cboden
Copy link
Member

cboden commented Dec 16, 2021

@WyriHaximus Anything we can do to fix the failing tests on 8.x?

@WyriHaximus
Copy link
Author

@cboden yeah will fix that as well 👍

@WyriHaximus
Copy link
Author

This is going to be a fun upgrade 😂

@cboden
Copy link
Member

cboden commented Dec 16, 2021

Would putting the phphunit versions in the opposite order, or perhaps only 4.x and 7.x satisfy some problems?

@WyriHaximus
Copy link
Author

Not sure, locally it only installs 4 some how, even though I'm running PHP 8.0

@WyriHaximus
Copy link
Author

@cboden Feel free to run, but tests will fail currently. Working on fixing them/

@WyriHaximus WyriHaximus changed the title Test on PHP 8.0 and 8.1 Test on PHP 8.0, 8.1, and 8.2 Jan 16, 2023
@WyriHaximus
Copy link
Author

Updated PR to also include PHP 8.2

@SimonFrings SimonFrings mentioned this pull request Mar 15, 2023
Open
@Tofandel
Copy link

This should also include #1060 as the warnings are not fixed in the tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WyriHaximus @frank9999 @cboden @Tofandel