Open
Conversation
fand
force-pushed
the
feat/pixel-ratio
branch
from
98b449e to
04afb32
Compare
fand
force-pushed
the
feat/pixel-ratio
branch
from
04afb32 to
3db4c08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for high pixel ratio rendering.
It allows us to get crisper output in HiDPI environments like Retina MacBook or iPhone.
This PR depends on the new APIs added in junkdog/beamterm#69 .
We cannot merge this until it's shipped first.
Changes
WebGL2BackendOptions.enable_auto_pixel_ratio()When enabled, it checks the pixel ratio on every render to detect window changes.
It then calls
Beamterm::set_pixel_ratio()to update WebGL viewport pixel ratio if necessary.Screenshots
I took screenshots in demo2:
before
after
We can see the text and edges are sharper in the 2nd screenshot.