Fixed invalid variable name in error handling #69
Conversation
It seems the errors should be compared as is, not to their negative.
| // may have not be created as expected or the file was already closed | ||
| // by the user, in which case we will simply ignore the error | ||
| if (e.errno != -_c.EBADF && e.errno != -c.ENOENT) { |
There was a problem hiding this comment.
Nice catch on the invalid variable, although we need the - here.
There was a problem hiding this comment.
@raszi, in my testing, the error codes had positive values. E.g. on Ubuntu, I consistently was getting an error because the temp file was already closed, and the value was EBADF (positive). See https://github.com/kartotherian/tilerator/blob/master/lib/fileParser.js#L215
There was a problem hiding this comment.
@raszi AFAIK nodejs always used negative values but it can be that behavior has been changed... - therefore my initial Math.abs(), you remember?
|
Came here to point out this referencing of an undefined variable. Looks like it's been fixed in master (October 2015) but not in the latest package on npm (September 2015). As for the positive / negative errno discussion. On my Mac with Node.js version 6.4, both c.ENOENT and c.EBADF are undefined. I believe these days the right thing to do is to check err.code against the strings 'EBADF' and / or 'ENOENT'. See nodejs/node-v0.x-archive#1905 (comment) for example. |
|
Fixed with #96 |
Fixed invalid variable reference
My IDE also auto-fixed trailing spaces in two places.