Use system include directories #954
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently all include directories are added as none system include directories. This might causes warnings and errors when compiling user code.
ooxi
force-pushed
the
patch/system-include
branch
from
1aee033
to
9fe8cf6
Compare
|
@kilograham I have updated the PR to work with the develop branch based upon 1.5.0 Would be great if we could merge this since it's the only remaining issue keeping me from running upstream pico-sdk :-) |
|
I don't quite follow why this is needed. I'm surprised if our headers are generating warnings? |
|
@peterharperuk The includes apparently cannot be marked as system includes by the user in CMake, nor flags such as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all include directories are added as none system include directories. This might causes warnings and errors when compiling user code.
Fixes #82 and #924