Only warn about Doxygen missing when Pico SDK is the top-level project #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This silences the following warning for projects that include the Pico SDK: ``` -- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE) ``` I don't think projects that include the pico-sdk would want to generate the Pico SDK documentation (perhaps with the sole exception of the example repo?), so this warning is not all that relevant outside of the top-level project.
|
Was this already fixed by #365 ? |
|
Yes; I didn't notice there was a develop branch. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This silences the following warning for projects that include the Pico SDK:
I don't think projects that include the pico-sdk would want to generate the
Pico SDK documentation (perhaps with the sole exception of the example repo?),
so this warning is not all that relevant outside of the top-level project.