Skip to content

Small API additions and minor fixes #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jun 2, 2021
Merged

Small API additions and minor fixes #406

merged 16 commits into from
Jun 2, 2021

Conversation

kilograham
Copy link
Contributor

No description provided.

@kilograham kilograham added this to the 1.2.0 milestone May 13, 2021
@kilograham kilograham self-assigned this May 13, 2021
@kilograham kilograham marked this pull request as draft May 13, 2021 01:07
@kilograham kilograham force-pushed the small_api_additions branch from 97ef2bf to 53cece4 Compare May 13, 2021 01:13
@kilograham kilograham linked an issue May 13, 2021 that may be closed by this pull request
clock_configure() doesn't remember the real frequency #368
Closed
lurch
lurch reviewed May 13, 2021
View reviewed changes
@kilograham kilograham force-pushed the small_api_additions branch from 04c77bb to c7ff4f6 Compare May 13, 2021 20:25
@kilograham kilograham changed the title Fill some small API gaps Small API additions and minor fixes May 13, 2021
@kilograham kilograham mentioned this pull request May 13, 2021
Closed
lurch
lurch reviewed May 13, 2021
View reviewed changes
@kilograham kilograham force-pushed the small_api_additions branch from 0f93250 to c58dd6e Compare May 13, 2021 22:02
@kilograham
Copy link
Contributor Author

fixes #165

@kilograham kilograham force-pushed the small_api_additions branch 2 times, most recently from 5e6038d to a2bf911 Compare May 13, 2021 22:26
lurch
lurch reviewed May 14, 2021
View reviewed changes
lurch
lurch reviewed May 14, 2021
View reviewed changes
lurch
lurch reviewed May 14, 2021
View reviewed changes
lurch
lurch reviewed May 14, 2021
View reviewed changes
lurch
lurch reviewed May 14, 2021
View reviewed changes
lurch
lurch reviewed May 14, 2021
View reviewed changes
lurch
lurch reviewed May 14, 2021
View reviewed changes
lurch
lurch reviewed May 14, 2021
View reviewed changes
lurch
lurch reviewed May 14, 2021
View reviewed changes
@lurch
Copy link
Contributor

lurch commented May 14, 2021

Ahh, sorry for the outdated PIO comments, I was going through the commits one at a time and didn't realise that a later commit modified the same files as an earlier commit!

lurch
lurch reviewed May 14, 2021
View reviewed changes
@kilograham kilograham force-pushed the small_api_additions branch from 598daff to b423894 Compare May 24, 2021 22:24
lurch
lurch reviewed May 24, 2021
View reviewed changes
lurch
lurch reviewed May 27, 2021
View reviewed changes
lurch
lurch reviewed May 27, 2021
View reviewed changes
lurch
lurch reviewed May 27, 2021
View reviewed changes
src/rp2_common/hardware_pio/include/hardware/pio.h Outdated
@@ -723,11 +723,12 @@ static inline void pio_set_irq1_source_enabled(PIO pio, enum pio_interrupt_sourc
hw_clear_bits(&pio->inte1, 1u << source);
}

/*! \brief Enable/Disable multiple sources on a PIO's IRQ 0
/*! \brief Enable/Disable multiple source on a PIO's IRQ 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like "multiple sources" was correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fxd

lurch
lurch reviewed May 27, 2021
View reviewed changes
lurch
lurch reviewed May 27, 2021
View reviewed changes
lurch
lurch reviewed May 27, 2021
View reviewed changes
lurch
lurch reviewed May 27, 2021
View reviewed changes
lurch
lurch reviewed May 27, 2021
View reviewed changes
lurch
lurch reviewed May 27, 2021
View reviewed changes
lurch
lurch reviewed May 27, 2021
View reviewed changes
lurch
lurch reviewed May 27, 2021
View reviewed changes
@kilograham kilograham force-pushed the small_api_additions branch from 6ef7ac7 to 1dbd71a Compare May 27, 2021 19:45
@kilograham kilograham linked an issue May 31, 2021 that may be closed by this pull request
No interrupt function in SDK for the PIO #165
Closed
@kilograham kilograham requested review from Wren6991 and liamfraser May 31, 2021 21:49
@kilograham kilograham marked this pull request as ready for review May 31, 2021 21:49
liamfraser
liamfraser previously approved these changes Jun 1, 2021
View reviewed changes
Wren6991
Wren6991 previously approved these changes Jun 2, 2021
View reviewed changes
@kilograham kilograham dismissed stale reviews from Wren6991 and liamfraser via 1b8c7ba June 2, 2021 18:11
@kilograham kilograham merged commit 5afa363 into develop Jun 2, 2021
@kilograham kilograham deleted the small_api_additions branch June 2, 2021 18:12
@lurch lurch mentioned this pull request Jun 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lurch lurch lurch left review comments

@Wren6991 Wren6991 Wren6991 left review comments

@liamfraser liamfraser liamfraser left review comments

Assignees

@kilograham kilograham

Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

clock_configure() doesn't remember the real frequency No interrupt function in SDK for the PIO
4 participants
@kilograham @lurch @Wren6991 @liamfraser