Skip to content

Fix WindowsCI (again) #2388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025
Merged

Fix WindowsCI (again) #2388

merged 1 commit into from
Apr 4, 2025

Conversation

lurch
Copy link
Contributor

@lurch lurch commented Mar 31, 2025

Use newer version of ninja

bb5b5f9 failed on Windows CI with:

 - ninja - A newer version of ninja (v1.12.1) is already installed.
 Use --allow-downgrade or --force to attempt to install older versions.
Error: Process completed with exit code 1.

However the preceding commit a5ba689 passed Windows CI just fine.

A bit of investigation reveals that the passing commit used GitHub runner image https://github.com/actions/runner-images/blob/win22/20250309.1/images/windows/Windows2022-Readme.md (which doesn't have ninja pre-installed) whereas the failing commit used GitHub runner image https://github.com/actions/runner-images/blob/win22/20250324.3/images/windows/Windows2022-Readme.md which has Ninja 1.12.1 pre-installed.

I don't think that we can assume that ninja is pre-installed on all GiitHub runner images yet, so rather than removing it from choco_packages.config (i.e. similar to what was done in #2241 ), just update the ninja install to a matching version instead, to hopefully suppress the "A newer version of ninja is already installed" error.

Use newer version of ninja
@lurch lurch requested a review from will-v-pi March 31, 2025 17:25
Copy link
Contributor

@will-v-pi will-v-pi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - and the fix for the next breakage when they eventually bump Ninja again will be removing it from the choco_packages, as by that point all runners will be on a version with Ninja pre-installed

@kilograham
Copy link
Contributor

can we just not use "latest"

@will-v-pi
Copy link
Contributor

can we just not use "latest"

Yeah, we could just delete the version option, instead of updating it to 1.12.1 - although probably still sensible to delete the Ninja entry once it's in the Windows runners by default (like the CMake entry has been deleted)

@lurch
Copy link
Contributor Author

lurch commented Apr 2, 2025

I'm not a Windows user, so I've never used choco_packages.config (and therefore I'm unable to test). @will-v-pi Feel free to close this PR and replace it with an alternative one. 🪟 🪟

@kilograham kilograham added this to the 2.1.2 milestone Apr 4, 2025
@kilograham kilograham merged commit 5edf1a0 into develop Apr 4, 2025
8 checks passed
@kilograham kilograham deleted the lurch-patch-1 branch April 4, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants