Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use newer version of ninja
bb5b5f9 failed on Windows CI with:
However the preceding commit a5ba689 passed Windows CI just fine.
A bit of investigation reveals that the passing commit used GitHub runner image https://github.com/actions/runner-images/blob/win22/20250309.1/images/windows/Windows2022-Readme.md (which doesn't have
ninja
pre-installed) whereas the failing commit used GitHub runner image https://github.com/actions/runner-images/blob/win22/20250324.3/images/windows/Windows2022-Readme.md which has Ninja 1.12.1 pre-installed.I don't think that we can assume that ninja is pre-installed on all GiitHub runner images yet, so rather than removing it from
choco_packages.config
(i.e. similar to what was done in #2241 ), just update the ninja install to a matching version instead, to hopefully suppress the "A newer version of ninja is already installed" error.