Remove assignment of cyw43 last_size/header/backplane_window variables #2306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are never used by the cyw43-driver code, because `F1_OVERFLOW_CHANGE` is disabled. Signed-off-by: Damien George <damien@micropython.org>
|
I have tested this change on a Pico W and Pico 2 W (using MicroPython, running some network tests on those boards with this change). It works. |
peterharperuk
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They variables are never used by the cyw43-driver code, because
F1_OVERFLOW_CHANGEis disabled.Fixes #2305 (see that issue for more detailed discussion).