Add additional Bazel config tinyUSB and pico_stdio_usb #2264
+10
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kilograham
reviewed
Feb 15, 2025
Contributor
Author
|
I chatted with @armandomontanez on Friday and I'm going to upload a narrower patch based on his feedback. |
mbrase
force-pushed
the
pico-shared-usb
branch
from
d878d50 to
1bf7317
Compare
Contributor
Author
|
I've uploaded a new patch which is a subset of the previous patch Add Bazel label flag for overriding tusb_config.h This adds |
mbrase
changed the title
This adds `//bazel/config:PICO_TINYUSB_CONFIG`, which is used to select which tusb_config.h gets linked into the tinyUSB port. This defaults to the tusb_config.h from the pico_stdio_usb (same as before), but allows Bazel users to override this config with their own.
mbrase
force-pushed
the
pico-shared-usb
branch
from
1bf7317 to
8669b97
Compare
Contributor
Author
|
Hi, I'm ready for this to be reviewed |
armandomontanez
approved these changes
Feb 25, 2025
Contributor
|
Bazel changes look good to me, sorry for the dealy. |
kilograham
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change the makes the following defines setable in Bazel:
LIB_TINYUSB_HOSTLIB_TINYUSB_DEVICEPICO_STDIO_USB_ENABLE_RESET_VIA_BAUD_RATEPICO_STDIO_USB_ENABLE_RESET_VIA_VENDOR_INTERFACEThis also adds
//bazel/config:PICO_TINYUSB_CONFIG, which allows overriding the "tusb_config.h" header used to build tinyUSB. This might be used to add additional USB interfaces while preserving the functionality from pico_stdio_usb.