Skip to content

update previous fix as 1.0 < clkdiv < 2.0 IS supported on RP2350 #2255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 17, 2025
Merged

update previous fix as 1.0 < clkdiv < 2.0 IS supported on RP2350 #2255

merged 3 commits into from
Feb 17, 2025

Conversation

kilograham
Copy link
Contributor

fixes #2189 more accurately

@kilograham kilograham requested a review from will-v-pi February 11, 2025 22:37
@kilograham kilograham added this to the 2.1.1 milestone Feb 11, 2025
lurch
lurch reviewed Feb 12, 2025
View reviewed changes
lurch
lurch reviewed Feb 12, 2025
View reviewed changes
will-v-pi
will-v-pi reviewed Feb 12, 2025
View reviewed changes
Copy link
Contributor

@will-v-pi will-v-pi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, other than @lurch’s comments and a small typo

peterharperuk
peterharperuk approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@peterharperuk peterharperuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after staring at this for some time. I think it makes sense.

@kilograham kilograham merged commit c691da8 into develop Feb 17, 2025
8 checks passed
@kilograham kilograham deleted the clock_divider branch February 17, 2025 16:53
@lurch lurch mentioned this pull request Feb 17, 2025
Open
will-v-pi pushed a commit to will-v-pi/pico-sdk that referenced this pull request Mar 20, 2025
@kilograham @will-v-pi
update previous fix as 1.0 < clkdiv < 2.0 IS supported on RP2350 (ras…
6bcecd7 
…pberrypi#2255)

* update previous fix as 1.0 < clkdiv < 2.0 IS supported on RP2350
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lurch lurch lurch left review comments

@will-v-pi will-v-pi will-v-pi left review comments

@peterharperuk peterharperuk peterharperuk approved these changes

Assignees
No one assigned
Labels
hardware_clocks
Projects
None yet
Milestone
2.1.1
Development

Successfully merging this pull request may close these issues.
4 participants
@kilograham @lurch @peterharperuk @will-v-pi