clarify clock_configure and make it return the correct value achieved for bad clock inputs #2225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for bad clock inputs
peterharperuk
approved these changes
Feb 4, 2025
lurch
reviewed
Feb 11, 2025
| @@ -287,7 +294,7 @@ bool clock_configure(clock_handle_t clock, uint32_t src, uint32_t auxsrc, uint32 | |||
| */ | |||
| void clock_configure_undivided(clock_handle_t clock, uint32_t src, uint32_t auxsrc, uint32_t src_freq); | |||
|
|
|||
| /*! \brief Configure the specified clock to use the undividded input source | |||
| /*! \brief Configure the specified clock to use the undivided input source | |||
There was a problem hiding this comment.
Hmmm, same 'brief' description for both clock_configure_undivided and clock_configure_int_divider - is that correct, or was it a copy'n'paste error?
|
Actually it turns out the RP2350 datasheet is incorrect and 1.x IS supported on RP2350… the datasheet will be updated and I’ll make a new PR to correct the function documentation |
will-v-pi
pushed a commit
to will-v-pi/pico-sdk
that referenced
this pull request
Mar 20, 2025
… for bad clock inputs (raspberrypi#2225)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2189