rationalize pico_float/pico_double libraries #2208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

kilograham merged 8 commits into develop from pico_float_double_cleanup

Feb 4, 2025

Contributor

kilograham commented Jan 23, 2025

on RP2350 _dcp variant now enables -msoft-float, since if you're using this at all it is likely because you don't want to use the VFP unit at all (to save stack space)
implement all float_ and double_ conversion functions in all pico_float_pico_ variants and pico_double_pico on RP2040 and RP2350 (many were missing in some combinations)
provide better granularity of what functions are wrapped in each case


          rationalize pico_float/pico_double libraries

2ab0333

* on RP2350 _dcp variant now enables -msoft-float, since if you're using this at all it is likely because you don't want to use the VFP unit at all (to save stack space)
* implement all float_ and double_ conversion functions in all pico_float_pico_ variants and pico_double_pico on RP2040 and RP2350 (many were missing in some combinations)
* provide better granularity of what functions are wrapped in each case

kilograham added this to the 2.1.1 milestone

Contributor Author

kilograham commented Jan 23, 2025

fixes #2160

Contributor Author

kilograham commented Jan 23, 2025

cc @armandomontanez - i fixed up the main bazel build, but did not attempt to add the new tests

lurch reviewed

View reviewed changes

src/rp2_common/pico_double/include/pico/double.h Outdated Show resolved Hide resolved

lurch reviewed

View reviewed changes

src/rp2_common/pico_double/include/pico/double.h Outdated Show resolved Hide resolved

lurch reviewed

View reviewed changes

src/rp2_common/pico_double/include/pico/double.h Outdated Show resolved Hide resolved

lurch reviewed

View reviewed changes

src/rp2_common/pico_float/include/pico/float.h Outdated Show resolved Hide resolved

lurch reviewed

View reviewed changes

src/rp2_common/pico_float/include/pico/float.h Outdated Show resolved Hide resolved

lurch reviewed

View reviewed changes

src/rp2_common/pico_float/include/pico/float.h Outdated Show resolved Hide resolved

lurch reviewed

View reviewed changes

src/rp2_common/pico_float/include/pico/float.h Outdated Show resolved Hide resolved

lurch reviewed

View reviewed changes

src/rp2_common/pico_float/include/pico/float.h Outdated Show resolved Hide resolved

lurch reviewed

View reviewed changes

src/rp2_common/pico_float/include/pico/float.h Outdated Show resolved Hide resolved

lurch reviewed

View reviewed changes

test/pico_float_test/CMakeLists.txt Outdated Show resolved Hide resolved

lurch reviewed

View reviewed changes

src/rp2_common/pico_float/include/pico/float.h Outdated Show resolved Hide resolved

lurch reviewed

View reviewed changes

src/rp2_common/pico_double/include/pico/double.h Outdated Show resolved Hide resolved

lurch reviewed

View reviewed changes

src/rp2_common/pico_double/include/pico/double.h Outdated Show resolved Hide resolved

lurch reviewed

View reviewed changes

src/rp2_common/pico_double/include/pico/double.h Outdated Show resolved Hide resolved

Contributor

armandomontanez commented Jan 24, 2025

cc @armandomontanez - i fixed up the main bazel build, but did not attempt to add the new tests

Thanks for the heads up. If Bazel starts to get in the way, just temporarily disable the checks and I'll do a pass to make it happy again.

kilograham added 4 commits

January 24, 2025 17:16


          fixup review comments

f2256ff


          mark custom_xxx_funcs_test.c as not in bazel build yet

5484c95


          oops; fix double2int to include all lower mantissa bits

e235c8e


          remove unrelated pio.h change

5e398e8

lurch reviewed

View reviewed changes

src/rp2_common/pico_double/include/pico/double.h Outdated Show resolved Hide resolved

lurch reviewed

View reviewed changes

test/pico_float_test/custom_double_funcs_test.c Outdated Show resolved Hide resolved

kilograham added 3 commits

January 27, 2025 08:22


          review tweaks

07f2d71


          various bug fixes based on review

e25a63a


          a few more fixes/tests

f8e9c70

Contributor Author

kilograham commented Feb 4, 2025

merging fixes post review with mark

kilograham merged commit e85c3e5 into develop

8 checks passed

kilograham deleted the pico_float_double_cleanup branch

February 4, 2025 22:19

will-v-pi pushed a commit to will-v-pi/pico-sdk that referenced this pull request


          rationalize pico_float/pico_double libraries (raspberrypi#2208)

4bbccce

* on RP2350 _dcp variant now enables -msoft-float, since if you're using this at all it is likely because you don't want to use the VFP unit at all (to save stack space)
* implement all float_ and double_ conversion functions in all pico_float_pico_ variants and pico_double_pico on RP2040 and RP2350 (many were missing in some combinations)
* provide better granularity of what functions are wrapped in each case

also marked custom_xxx_funcs_test.c as not in bazel build yet

lurch added a commit that referenced this pull request


          Ensure each test has a unique name (followup to #2208)

aa6836a

mainly by fixing typos!

lurch mentioned this pull request

Ensure each test has a unique name (followup to #2208) #2443

Merged

kilograham pushed a commit that referenced this pull request


          Ensure each test has a unique name (followup to #2208) (#2443)

ae332b3

mainly by fixing typos!

hanshuebner mentioned this pull request

Set PICO_RP2350A to 1 for Pimoroni PGA2350 #2474

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet