Fix missing headers leading to #include failing when pulling in hardware_irq and pico_bootrom #1956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabizri
changed the title
Replace `pico_runtime_init` by `pico_runtime_init_headers` From discussion on PR raspberrypi#1956 (raspberrypi#1956 (comment))
peterharperuk
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @kilograham (in #1929 (comment)), add
pico_runtime_initas well aspico_runtimeandboot_picobin_headersto theCMakeLists.txts defininghardware_irqandpico_bootrom_headers.While the issue initially was reported only for
hardware_irqmissingpico_runtime_init, the same issue affect the other mentionned.Fixes #1929