Skip to content

add Adafruit feather, itsybitsy, qtpy board headers #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 26, 2021

Conversation

hathach
Copy link
Contributor

@hathach hathach commented Feb 26, 2021

This PR adds board headers for Adafruit

I didn't see any boards define SPI pin, but the name is very obvious. Let me know if you would like to change the name

  • PICO_DEFAULT_SPI
  • PICO_DEFAULT_SPI_MOSI_PIN
  • PICO_DEFAULT_SPI_MISO_PIN
  • PICO_DEFAULT_SPI_SCK_PIN

PS: It would be nice if this PR is merged before #192 , so that it got updated as well.

@ladyada

@lurch
Copy link
Contributor

lurch commented Feb 26, 2021

PICO_DEFAULT_SPI_MOSI_PIN
PICO_DEFAULT_SPI_MISO_PIN

That would make sense if those functions were on fixed pins, but IIRC the "MOSI" and "MISO" pins depend on whether you're using the SPI on the RP2040 in master-mode or slave-mode? Which is why https://www.raspberrypi.org/documentation/rp2040/getting-started/ simply labels them as "SPI RX" and "SPI TX".
See section 4.4.3.15 in https://datasheets.raspberrypi.org/rp2040/rp2040-datasheet.pdf

But I don't want to second-guess how @kilograham will be handling PICO_DEFAULT_SPI_* in #192 , so probably best to hold fire for now 😉

@kilograham kilograham merged commit 248c7e9 into raspberrypi:board-headers Feb 26, 2021
@kilograham
Copy link
Contributor

PICO_DEFAULT_SPI_MOSI_PIN
PICO_DEFAULT_SPI_MISO_PIN

That would make sense if those functions were on fixed pins, but IIRC the "MOSI" and "MISO" pins depend on whether you're using the SPI on the RP2040 in master-mode or slave-mode? Which is why https://www.raspberrypi.org/documentation/rp2040/getting-started/ simply labels them as "SPI RX" and "SPI TX".
See section 4.4.3.15 in https://datasheets.raspberrypi.org/rp2040/rp2040-datasheet.pdf

But I don't want to second-guess how @kilograham will be handling PICO_DEFAULT_SPI_* in #192 , so probably best to hold fire for now wink

ha, i didn't see this, and found it myself. I would want to use TX and RX. Are you currently using these defines?

@hathach
Copy link
Contributor Author

hathach commented Feb 26, 2021

ha, i didn't see this, and found it myself. I would want to use TX and RX. Are you currently using these defines?

Currently we don't use it at all, just though it would be nice to have. We are happy whichever standard name that you choose. Would you like us to make another PR to change the name to SPI RX & TX ?

@hathach hathach deleted the adafruit-board-headers branch February 26, 2021 16:59
@kilograham
Copy link
Contributor

nope i already have merged it in and will fix it up

@kilograham kilograham modified the milestone: 1.0.2 Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants