Skip to content

Add btstack files missing from build #1380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 7, 2023
Merged

Add btstack files missing from build #1380

merged 2 commits into from
Jun 7, 2023

Conversation

peterharperuk
Copy link
Contributor

Fixes #1379

@peterharperuk peterharperuk added this to the 1.5.1 milestone May 18, 2023
@peterharperuk peterharperuk requested a review from kilograham May 18, 2023 10:35
@peterharperuk peterharperuk self-assigned this May 18, 2023
@peterharperuk peterharperuk changed the title Add missing btstack files WIP: Add missing btstack files May 18, 2023
@peterharperuk
Copy link
Contributor Author

Needs us to update btstack first

@peterharperuk peterharperuk removed their assignment May 22, 2023
kilograham
kilograham requested changes May 26, 2023
View reviewed changes
Copy link
Contributor

@kilograham kilograham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small thing, but (and it looks like there are a cople of offenders with md5 and yxml, but the majority of this is in alphabetical order, so best to maintain

@peterharperuk peterharperuk force-pushed the missing_btstack_files branch from de70f33 to 082ae8e Compare June 7, 2023 15:38
@peterharperuk
Copy link
Contributor Author

fixed alpha order and moved the classic file to the right lib!

@kilograham kilograham merged commit ab76609 into raspberrypi:develop Jun 7, 2023
@peterharperuk
Copy link
Contributor Author

Oh dear - still says WIP. I thought that would block it.

@kilograham kilograham changed the title WIP: Add missing btstack files Add btstack files missing from build Jun 7, 2023
@kilograham kilograham mentioned this pull request Jun 7, 2023
Closed
@usedbytes usedbytes mentioned this pull request Nov 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kilograham kilograham kilograham approved these changes

Assignees

@peterharperuk peterharperuk

Labels
None yet
Projects
None yet
Milestone
1.5.1
Development

Successfully merging this pull request may close these issues.
2 participants
@peterharperuk @kilograham