Skip to content

change blink to use PICO_DEFAULT_LED_PIN to support other boards #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 22, 2021
Merged

change blink to use PICO_DEFAULT_LED_PIN to support other boards #57

merged 2 commits into from
Feb 22, 2021

Conversation

hathach
Copy link
Contributor

@hathach hathach commented Feb 18, 2021

This help the example to run with upcoming board without code modification from user.

@lurch
Copy link
Contributor

lurch commented Feb 18, 2021

There's also similar in:
https://github.com/raspberrypi/pico-examples/blob/master/picoboard/blinky/blinky.c
https://github.com/raspberrypi/pico-examples/blob/master/pio/pwm/pwm.c

@hathach hathach mentioned this pull request Feb 18, 2021
Closed
@Wren6991
Copy link
Contributor

Wren6991 commented Feb 19, 2021 •
edited
Loading

Note the hello_double_tap change will conflict with #53 -- could you remove that one from this PR please? (edit: maybe amend and force-push, not sure how smart github is with detecting whether a squash will apply?)

Otherwise all looks great, thanks!

@lurch
Copy link
Contributor

lurch commented Feb 19, 2021

#53 has now been merged, so (hopefully) all you need to do is rebase against the latest develop branch.

@hathach hathach force-pushed the blink-PICO_DEFAULT_LED_PIN branch from 1616c48 to a0adcac Compare February 22, 2021 04:27
@hathach
Copy link
Contributor Author

hathach commented Feb 22, 2021

I have rebased and push-force

@Wren6991 Wren6991 merged commit 1be0e7f into raspberrypi:develop Feb 22, 2021
kilograham pushed a commit that referenced this pull request Mar 5, 2021
@hathach @kilograham
change blink to use PICO_DEFAULT_LED_PIN to support other boards (#57)
86ca3fe 
* change blink to use PICO_DEFAULT_LED_PIN to support other boards

* also update pio/pwm and picoboard/blinky system/hello_double_tap
@hathach hathach deleted the blink-PICO_DEFAULT_LED_PIN branch March 18, 2021 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wren6991 Wren6991 Wren6991 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hathach @lurch @Wren6991