drm: rp1: VEC and DPI drivers: Fix bug #5901 #5925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rework probe() to use devm_drm_dev_alloc(), embedding the DRM device in the DPI or VEC device as now seems to be recommended. Change order of resource allocation and driver initialization. This prevents it trying to write to an unmapped register during clean-up, which previously could crash. Signed-off-by: Nick Hollinghurst <nick.hollinghurst@raspberrypi.com>
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Feb 7, 2024
kernel: Improve I2C timing (again) See: raspberrypi/linux#5916 kernel: drm/vc4: Drop planes that have 0 destination size See: raspberrypi/linux#5929 kernel: drm: rp1: VEC and DPI drivers: Fix bug #5901 See: raspberrypi/linux#5925 kernel: drivers: media: cfe: Increase default size of embedded buffer See: raspberrypi/linux#5923 kernel: RP1 VEC: Use tv_mode from command line, align enum with drm_connector; tidy See: raspberrypi/linux#5885 kernel: ARM: dts: Standardise downstream Pi GPIO pin names See: raspberrypi/linux#5902 kernel: ASoC: DACplusADCPro - fix 16bit sample support in clock consumer mode See: raspberrypi/linux#5919 kernel: ASoC: adds support for Hifiberry AMP4Pro to the dacplus driver See: raspberrypi/linux#5918 kernel: ASoC: DACplus - fix 16bit sample support in clock consumer mode See: raspberrypi/linux#5917
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Feb 7, 2024
kernel: Improve I2C timing (again) See: raspberrypi/linux#5916 kernel: drm/vc4: Drop planes that have 0 destination size See: raspberrypi/linux#5929 kernel: drm: rp1: VEC and DPI drivers: Fix bug #5901 See: raspberrypi/linux#5925 kernel: drivers: media: cfe: Increase default size of embedded buffer See: raspberrypi/linux#5923 kernel: RP1 VEC: Use tv_mode from command line, align enum with drm_connector; tidy See: raspberrypi/linux#5885 kernel: ARM: dts: Standardise downstream Pi GPIO pin names See: raspberrypi/linux#5902 kernel: ASoC: DACplusADCPro - fix 16bit sample support in clock consumer mode See: raspberrypi/linux#5919 kernel: ASoC: adds support for Hifiberry AMP4Pro to the dacplus driver See: raspberrypi/linux#5918 kernel: ASoC: DACplus - fix 16bit sample support in clock consumer mode See: raspberrypi/linux#5917
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework probe() to use devm_drm_dev_alloc(), embedding the DRM device in the DPI or VEC device as now seems to be recommended.
Change order of resource allocation and driver initialization. This prevents it trying to write to an unmapped register during clean-up, which previously could crash.