Skip to content

Pisound updates for Pi 5 #5872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Conversation

gtrainavicius
Copy link
Contributor

  • Don't export the button's GPIO via sysfs GPIO class from the kernel module.
  • Use 100kHz SPI speed for Pi 5.

Btw, I'm unsure if these lines are needed in pisound-pi5-overlay.dts:

/ {
	compatible = "brcm,bcm2712";
};

Let me know if the lines should be removed. :)

Signed-off-by: Giedrius Trainavičius <giedrius@blokas.io>
@pelwell
Copy link
Contributor

pelwell commented Jan 22, 2024

That looks OK to me. The bcm2712 compatible string helps the checker tools know which devices it can be used on.

If you can just add a placeholder README entry I'll merge it - something in the style of:

Name:   disable-wifi-pi5
Info:   See disable-wifi

@pelwell
Copy link
Contributor

pelwell commented Jan 22, 2024

Sorry - one thing I should have said before is that we appreciate it if the DT patches are kept separate from the driver patches, because all the DT patches get squashed together when the tree is rebased.

@pelwell
Copy link
Contributor

pelwell commented Jan 22, 2024

"one think" - ha ha, something I obviously didn't do.

@gtrainavicius
Copy link
Contributor Author

Do you mean you'd like the pisound.c changes to be placed in a separate commit, or in another pull request entirely?

Signed-off-by: Giedrius Trainavičius <giedrius@blokas.io>
… and specify spi-speed-hz override for Pi 5.

Signed-off-by: Giedrius Trainavičius <giedrius@blokas.io>
@gtrainavicius
Copy link
Contributor Author

I've split off the Device Tree changes into its own commit, and there's 2 commits for pisound.c

@pelwell
Copy link
Contributor

pelwell commented Jan 22, 2024

That's great.

@pelwell pelwell merged commit 92123f0 into raspberrypi:rpi-6.1.y Jan 22, 2024
@gtrainavicius
Copy link
Contributor Author

@pelwell, quick question - when is the next kernel release via rpi-update planned?

@pelwell
Copy link
Contributor

pelwell commented Jan 23, 2024

You just missed one yesterday. Ordinarily it would be a few days to a week until the next one, but this time it's more complicated because our master branch is about to switch over to rpi-6.6.y. Fortunately your changes have been ported over to 6.6 so they will be in the next release, one way or the other.

@gtrainavicius
Copy link
Contributor Author

We have some eager Pi 5 and Pisound users waiting for this fix to be released, do you have any estimate on when a new build will be out? Could a build on rpi-6.1y be triggered?

@pelwell
Copy link
Contributor

pelwell commented Jan 30, 2024

They can sudo rpi-update rpi-6.1.y to get the latest build at any time.

@gtrainavicius
Copy link
Contributor Author

This pull request didn't make it to 6.1.74, or did it?

@pelwell
Copy link
Contributor

pelwell commented Jan 30, 2024

Passing kernel branch names to rpi-update gets you the latest auto-build of the top-of-tree for that branch.

Try it.

@gtrainavicius
Copy link
Contributor Author

Ah ok, I didn't know this, thank you!

popcornmix added a commit to raspberrypi/firmware that referenced this pull request Feb 8, 2024
See: raspberrypi/linux#5923

kernel: overlays: Delete deprecated overlay mpu6050

kernel: overlays: Correct some compatible strings

kernel: ASoC: DACplusADCPro - fix 16bit sample support in clock consumer mode
See: raspberrypi/linux#5919

kernel: ASoC: adds support for Hifiberry AMP4Pro to the dacplus driver
See: raspberrypi/linux#5918

kernel: ASoC: DACplus - fix 16bit sample support in clock consumer mode
See: raspberrypi/linux#5917

kernel: Improve I2C timing (again)
See: raspberrypi/linux#5916

kernel: Update PiTFT overlays for compatibility and consistency
See: raspberrypi/linux#5903

kernel: Support non-standard I2C timings on Pi 5
See: raspberrypi/linux#5853

kernel: overlays: Add pcie-32bit-dma-pi5-overlay to enable 32bit DMA on the Pi 5's external PCIe interface
See: raspberrypi/linux#5897

kernel: Improvement on backup-switchover-mode overlay value definitions
See: raspberrypi/linux#5884

kernel: Pisound updates for Pi 5
See: raspberrypi/linux#5872
popcornmix added a commit to raspberrypi/rpi-firmware that referenced this pull request Feb 8, 2024
See: raspberrypi/linux#5923

kernel: overlays: Delete deprecated overlay mpu6050

kernel: overlays: Correct some compatible strings

kernel: ASoC: DACplusADCPro - fix 16bit sample support in clock consumer mode
See: raspberrypi/linux#5919

kernel: ASoC: adds support for Hifiberry AMP4Pro to the dacplus driver
See: raspberrypi/linux#5918

kernel: ASoC: DACplus - fix 16bit sample support in clock consumer mode
See: raspberrypi/linux#5917

kernel: Improve I2C timing (again)
See: raspberrypi/linux#5916

kernel: Update PiTFT overlays for compatibility and consistency
See: raspberrypi/linux#5903

kernel: Support non-standard I2C timings on Pi 5
See: raspberrypi/linux#5853

kernel: overlays: Add pcie-32bit-dma-pi5-overlay to enable 32bit DMA on the Pi 5's external PCIe interface
See: raspberrypi/linux#5897

kernel: Improvement on backup-switchover-mode overlay value definitions
See: raspberrypi/linux#5884

kernel: Pisound updates for Pi 5
See: raspberrypi/linux#5872
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants