Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further EMC2305 tweaks #5441

Merged
merged 2 commits into from
Apr 24, 2023
Merged

Further EMC2305 tweaks #5441

merged 2 commits into from
Apr 24, 2023

Commits on Apr 21, 2023

  1. hwmon: emc2305: Change OF properties pwm-min & pwm-max to u8 

    There is no DT binding for emc2305 as mainline are still
discussing how to do a generic fan binding.
The 5.15 driver was reading the "emc2305," properties
"cooling-levels", "pwm-max", "pwm-min", and "pwm-channel" as u8.
The overlay was writing them as u16 (;) so it was working.

The 6.1 driver was reading as u32, which failed as there is
insufficient data.

As this is all downstream only, revert to u8 to match 5.15.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
    @6by9
    6by9 committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    24ed7c5 View commit details
    Browse the repository at this point in the history

  2. dtoverlays: Change i2c-fan pwm-max/min overrides to u8 

    The driver is only reading a u8, so change the overlay to match.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
    @6by9
    6by9 committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    e1e2643 View commit details
    Browse the repository at this point in the history