Skip to content

Remove references to cam1 when setting camera dtoverlays as it doesn'… #4088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2025

Conversation

JamesH65
Copy link
Contributor

…t aactually exist

@JamesH65 JamesH65 requested a review from lurch April 29, 2025 16:22
@JamesH65
Copy link
Contributor Author

@6by9 for review - for some reason Github won't let me add you as a reviewer

@lurch lurch mentioned this pull request Apr 29, 2025
@lurch
Copy link
Contributor

lurch commented Apr 29, 2025

@6by9 for review - for some reason Github won't let me add you as a reviewer

I noticed the same - I think it might be because he doesn't have commit/write-access to this repo? ping @lloydalexporter

@6by9
Copy link
Contributor

6by9 commented Apr 29, 2025

@6by9 for review - for some reason Github won't let me add you as a reviewer

I noticed the same - I think it might be because he doesn't have commit/write-access to this repo? ping @lloydalexporter

Correct. When I clicked approve on lurch's other PR removing ,cam1 overrides, it said I'd approved with read-only access.

@JamesH65 JamesH65 merged commit 07dc7fa into develop Apr 30, 2025
1 check passed
@lurch lurch deleted the remove_cam1_directive_from_cm_setup branch April 30, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants