-
Notifications
You must be signed in to change notification settings - Fork 2k
Split out camera documentation v2 #2673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split out camera documentation v2 #2673
Conversation
Move the camera software documentation into a new section under Computers. Keep the camera hardware documentation in the existing Accessories space. Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
Update the maximum exposure time numbers, and while at it, fold the table into the hardware comparison table above. Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
- Remove Linux integration and C programming API rows - Update resolution list for imx219 and imx477 - Add imx477 sensor size Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
This does not belong in any camera documentation section. It ought to be re-instated in a future product sheet or product brief section. Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
- s/Raspberry Pi is transitioning/Raspberry Pi has transitioned/ - Add audio-samplerate commandline option for libcamera-vid - Add dependencies for libav integration - Add more obvious links between the camera software and modules documents Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
Remove the section from the camera hardware document, and include the existing filter removal adoc file to avoid duplicating the contents. Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
Add a large warning box at the start of the Raspicam section noting that it is now deprecated. Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
documentation/asciidoc/computers/camera/libcamera_apps_packages.adoc
Outdated
Show resolved
Hide resolved
Okay, so the plan is to merge this branch to |
Correct. I'll fix up the above and push and update shortly. |
Right. Let's keep the original branch around until this closes, but when this merges we need to remember close both branches! |
Few little comments, but mostly LGTM. I assume this all builds cleanly on your local machine @naushir ? |
Yup, all building fine for me locally. New changes have been pushed! |
844eeb9
to
02142e5
Compare
- s/accessories/camera hardware/ - s/Github/GitHub/ - Remove the sentence about Python bindings missing in libcamera Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
02142e5
to
5e768b4
Compare
@aallan I've only looked at the changes visible on the "Files changed" tab, and haven't read through the whole camera documentation to see if the structure / ordering still makes sense, but from what I've seen this LGTM. |
@@ -1 +1,3 @@ | |||
include::camera/camera_hardware.adoc[] | |||
|
|||
include::camera/hqcam_filter_removal.adoc[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, looking at the git history of that file, it looks like @aallan moved the original content out into the separate include-file (back in August 2021), but then forgot to edit the main body-text to use that include. 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did wonder why it was duplicated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doh!
Okay, ready to merge folks? |
Go for it!! |
Okay, got to run across town now. Huh, we have merge conflicts. That's odd. |
Redo of #2667