Skip to content

CE #2649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 19, 2022
Merged

CE #2649

merged 4 commits into from
Oct 19, 2022

Conversation

LizUpton
Copy link
Contributor

Lost quite a lot of verbiage.

Leaving line 48 for now; to revisit when we've moved things over.

Lost quite a lot of verbiage. 

Leaving line 48 for now; to revisit when we've moved things over.
@aallan aallan added copy edit more than a typo audio 🔊 labels Oct 17, 2022
the recording of audio from the built in MEMS microphone, from stereo Phono sockets (AUX
IN) or 2 x mono external Electret microphones. Playback is through stereo Phono sockets (AUX OUT)
the recording of audio from the built-in MEMS microphone, from stereo phono sockets (AUX
IN) or two mono external electret microphones. Playback is through stereo phono sockets (AUX OUT)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the risk of resurrecting the hydra again, did we decide whether the Codec Zero board supports one or two external microphones @tobybroberts ?

Comment on lines 50 to 53
* Mono MEMS mic recording, mono speaker playback
* Mono MEMS mic recording, mono AUX OUT playback
* Stereo AUX IN recording, stereo AUX OUT playback
* Stereo MIC1/MIC2 recording, stereo AUX OUT playback
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we haven't already, I guess we ought to check that all of these combinations do actually work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Off you go then! (Not now; you've got other things to be doing, but if you wouldn't mind assigning yourself a task in Asana for some time in the bold future, that'd be great.)

@@ -125,7 +118,7 @@ pcm.!default {
}
----

Ctrl X, Y and Enter to save and one final reboot to complete the configuration:
Ctrl X, Y and Enter to save, and reboot once more to complete the configuration:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"and reboot once more"
I suspect you could probably edit all the config files in one go, and just do a single reboot at the end?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving this one for now: happy for you to make a decision @aallan @lurch.

@lurch
Copy link
Contributor

lurch commented Oct 18, 2022

Still a few "MUTE" in all-caps towards the end of the file.

@@ -1,12 +1,12 @@
== Configuration

A pre-programmed EEPROM (Electrically Erasable Programmable Read-only Memory) is included on all Raspberry Pi audio boards. By doing so, Raspberry Pi OS is able to automatically detect and configure itself, enabling Raspberry Pi audio boards to be plug-and-play. Using Raspberry Pi OS (32-bit) with the Desktop environment and your board attached, you can utilise the built in GUI (Graphical User Interface) by right clicking on the audio settings in the top right hand corner of your screen, which allows you to switch between the on-board audio settings and the HAT audio settings:
A pre-programmed EEPROM is included on all Raspberry Pi audio boards. Raspberry Pi audio boards are designed to be plug-and-play; Raspberry Pi OS is able to automatically detect and configure itself. In Raspberry Pi OS, right-clicking on the audio settings in the top right-hand corner of your screen will allow you to switch between the on-board audio settings and the HAT audio settings:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a minor quibble, but perhaps the latter part of "Raspberry Pi audio boards are designed to be plug-and-play; Raspberry Pi OS is able to automatically detect and configure itself." could be reworded to "Raspberry Pi OS is able to automatically detect them and configure itself appropriately." as otherwise it might not be clear what Raspberry Pi OS is detecting? 🤷

@aallan aallan merged commit 90ae0f2 into iqaudio Oct 19, 2022
@aallan aallan deleted the LizUpton-patch-7 branch October 19, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audio 🔊 copy edit more than a typo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants