Style, rewording #2642
Style, rewording #2642
Conversation
A spot of edit for length too.
| PRO/DAC{plus}/DigiAMP{plus}) | ||
| This can be achieved by ensuring the 'Audio output' section of `/etc/mpd.conf` has the 'mixer_control' | ||
| line. Below is an example for the Texas Instruments-based boards (DAC | ||
| PRO/DAC{plus}/DigiAMP{plus}): |
There was a problem hiding this comment.
Feels a bit uncomfortable with no spaces between the slashes here? (or maybe that's just me)
Also, "Texas Instruments-based boards" feels like a level of technical detail that the users shouldn't need to know?
There was a problem hiding this comment.
Yeah, the TI bit had me vacillating when I did the first pass. I'll kill it. Slashes/spaces is a style guide thing; no spaces for consistency.
Not fixing the TI reference for now; another one for a sit-down conversation.
| * The rotary encoders we have used and tested are the Alpha three-pin rotary encoder | ||
| RE160F-40E3-20A-24P, the ALPS EC12E2430804 (RS: 729-5848), and the Bourns ECW0JB24-AC0006L (RS: 263-2839). | ||
| * The barrel connector used for powering the DigiAMP{plus} is 2.5mmID, 5.5mmOD, 11mm. |
There was a problem hiding this comment.
Space between 'mm' and 'ID' and 'OD'?
There was a problem hiding this comment.
@aallan More discussion about the barrel connector here ☝️
There was a problem hiding this comment.
Oh yeah, ID and OD. Interesting.
There was a problem hiding this comment.
There was a problem hiding this comment.
We should describe it (in both places) like this then, "via a DC 5521 centre positive barrel connector (5.5mm × 2.1mm × 11mm)" assuming it is a centre positive barrel?
There was a problem hiding this comment.
...except the connector here has a 2.5mm inside diameter, which is different to the Build HAT's 2.1mm inside diameter 😜
There was a problem hiding this comment.
...and this is why we all hate barrel jacks
There was a problem hiding this comment.
This one also requires a conversation in person. Let's talk tomorrow.
|
IMHO the whole "Using external USB devices" section ought to be chopped out. |
|
The FAQ isn't (shouldn't) be displayed any more. I asked @toby to integrate anything relevant into the text. The existence of a FAQ is a failure of the documentation, it is not in itself documentation. AFAIK this file should just be deleted as it isn't used any more. |
|
Bizarrely the file is named |
A spot of edit for length too.