Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V0.18.0 #711

Merged
merged 2 commits into from
Jul 28, 2020
Merged

V0.18.0 #711

merged 2 commits into from
Jul 28, 2020

Conversation

rasbt
Copy link
Owner

@rasbt rasbt commented Jul 28, 2020

Description

Related issues or pull requests

Pull Request Checklist

  • Added a note about the modification or contribution to the ./docs/sources/CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./mlxtend/*/tests directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under mlxtend/docs/sources/ (if applicable)
  • Ran PYTHONPATH='.' pytest ./mlxtend -sv and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., PYTHONPATH='.' pytest ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv)
  • Checked for style issues by running flake8 ./mlxtend

@rasbt rasbt merged commit 35f9061 into master Jul 28, 2020
@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.677% when pulling e82b2be on v0.18.0 into 081be59 on master.

@azrdev
Copy link

azrdev commented Aug 4, 2020

You created a github tag but not a github release. On pypi it's also still on 0.17.3, is that intended?

@rasbt
Copy link
Owner Author

rasbt commented Aug 4, 2020

The GitHub tag for this is 0.17.3. I initially named this branch 0.18 but then decided to make it a 0.17.2 -> 0.17.3 release rather than 0.17.2 -> 0.18.0 because it is mainly a bugfix release.

@azrdev
Copy link

azrdev commented Aug 9, 2020

Thank you for this clarification!

@rasbt rasbt deleted the v0.18.0 branch November 12, 2020 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants