-
Notifications
You must be signed in to change notification settings - Fork 12.1k
Added comments in class SimpleTokenizerV1 #918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| "metadata": {}, | ||
| "outputs": [ | ||
| { | ||
| "name": "stdout", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to create this PR. The comments here in this cell look good, but I see that there are also changes in other places.
I prefer not to merge the other changes here.
Reply via ReviewNB
|
Thank you for responding. I will be reviewing my changes and make sure the notebook is not disturbed much. |
|
No problem.
Sure, that's fine. But since your changes are only comments, I think it would be easiest to just apply the comments to the original notebook without rerunning the notebook. |
To ease the understanding of each statement while referencing with the lecture video, comments are added.