Skip to content

Update IsNumericFilter.php #2230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 20, 2025
Merged

Update IsNumericFilter.php #2230

merged 3 commits into from
Apr 20, 2025

Conversation

G4Zz0L1
Copy link
Contributor

@G4Zz0L1 G4Zz0L1 commented Mar 4, 2025

Fixes issues 2229

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

lrljoe and others added 3 commits February 28, 2025 22:44
* Link column fix (rappasoft#2223)

* Add handling for From field for "LinkColumn"

* Update ChangeLog
Fixes issues 2229
@lrljoe
Copy link
Collaborator

lrljoe commented Apr 1, 2025

Thanks, I will review this week, apologies but I've been on holiday

@lrljoe lrljoe changed the base branch from master to development April 1, 2025 12:32
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.96%. Comparing base (0036a9a) to head (28efa5a).
Report is 34 commits behind head on development.

Additional details and impacted files
@@                Coverage Diff                @@
##             development    #2230      +/-   ##
=================================================
+ Coverage          89.94%   89.96%   +0.02%     
- Complexity          2149     2154       +5     
=================================================
  Files                242      242              
  Lines               4851     4853       +2     
=================================================
+ Hits                4363     4366       +3     
+ Misses               488      487       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lrljoe
Copy link
Collaborator

lrljoe commented Apr 17, 2025

Looking at this over this weekend

@lrljoe lrljoe merged commit 67a8a9d into rappasoft:development Apr 20, 2025
11 of 12 checks passed
@lrljoe lrljoe mentioned this pull request May 3, 2025
lrljoe added a commit that referenced this pull request May 3, 2025
* Link column fix (#2223)

* Add handling for From field for "LinkColumn"

* Fix styling

* Update ChangeLog

* docs: add reminder of requirement to use toggle method (#2208)

Co-authored-by: Joe <104938042+lrljoe@users.noreply.github.com>

* Update IsNumericFilter.php (#2230)

* Link column fix (#2223) (#2224)

* Link column fix (#2223)

* Add handling for From field for "LinkColumn"

* Update ChangeLog

* Update IsNumericFilter.php

Fixes issues 2229

---------

Co-authored-by: Joe <104938042+lrljoe@users.noreply.github.com>

* Fix styling

* Boolean filter for bootstrap (#2244)

* Add BooleanFilter option for Bootstrap

* Add BS4 Support

* Update docs

* Fixes for livewire component column (#2245)

* Initial Commit

* Fix styling

* Initial Commit

* Fix styling

* Adjust test

* Fix styling

* Use test-livewire-column-component

* Additional Tests for LivewireComponentColumn

* Fix styling

* Add getContents Test

* TypeHint/PHPDoc Tidying (#2246)

* Fix broken typehints

* Minor tweaks to Footer/SecondaryHeader to ensure presence of callback prior to executing

* Fix styling

* PHPDoc additions

* Fix styling

* Update ChangeLog for TypeHintFixes

* Fix styling

* FilterPillData and StandardFilterPillData phpdocs

* Fix styling

* Add Wrapper Options to ArrayColumn (#2255)

* Add Wrapper Options to FlexCol

* Fix styling

* Moving getContents Back

* Fix styling

* Add Docs

* Add Wrapper Manual Tests

* Fix styling

* Update to test separator

* Fix styling

* Improved pagination UX (#2251)

* Link column fix (#2223) (#2224)

* Link column fix (#2223)

* Add handling for From field for "LinkColumn"

* Update ChangeLog

* Improved pagination UX

---------

Co-authored-by: Joe <104938042+lrljoe@users.noreply.github.com>

* Fixed collapsed function bug with tailwind CSS on mobile version (#2228)

* v3.7.2 updates (#2256)

---------

Co-authored-by: da-mask <1960334+da-mask@users.noreply.github.com>
Co-authored-by: G4Zz0L1 <g4zz0l10@gmail.com>
Co-authored-by: Daniel Škopek <117641078+daniel-skopek@users.noreply.github.com>
Co-authored-by: CarlosChub27 <163057406+CarlosChub27@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants