Skip to content

Filter Rationalisation & Livewire Array Filter improvements #2191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Feb 9, 2025

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Jan 31, 2025

This is a significant re-write of how Livewire Array Filters behave, utilising client-side methods to synchronise Pills to mitigate larger lifecycle events.

This also rationalises some of the codebase into sensible locations.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 55.96330% with 96 lines in your changes missing coverage. Please review.

Project coverage is 90.04%. Comparing base (d56dc78) to head (7a945b6).

Files with missing lines Patch % Lines
...Traits/Filters/HandlesLivewireComponentFilters.php 0.00% 17 Missing ⚠️
.../Traits/HandlesCorePropertiesForExternalFilter.php 0.00% 15 Missing ⚠️
src/Traits/Filters/HasFilterCore.php 0.00% 14 Missing ⚠️
...rs/Traits/Styling/HandlesFilterPillsAttributes.php 14.28% 12 Missing ⚠️
...ers/Traits/HandlesTableEventsForExternalFilter.php 0.00% 7 Missing ⚠️
.../Configuration/FilterPillsStylingConfiguration.php 56.25% 7 Missing ⚠️
src/Traits/Filters/Helpers/FilterHelpers.php 0.00% 6 Missing ⚠️
src/DataTransferObjects/Filters/FilterPillData.php 87.50% 5 Missing ⚠️
...c/External/Filters/LivewireArrayExternalFilter.php 0.00% 4 Missing ⚠️
...ers/Traits/HandlesCoreMethodsForExternalFilter.php 0.00% 3 Missing ⚠️
... and 4 more

❌ Your patch check has failed because the patch coverage (55.96%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@                Coverage Diff                @@
##             development    #2191      +/-   ##
=================================================
- Coverage          91.50%   90.04%   -1.47%     
- Complexity          2018     2104      +86     
=================================================
  Files                228      237       +9     
  Lines               4544     4701     +157     
=================================================
+ Hits                4158     4233      +75     
- Misses               386      468      +82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrljoe
Copy link
Collaborator Author

lrljoe commented Jan 31, 2025

Requires:

  • Adding documentation explaining best practices for a Livewire Array Filter
  • Adding tests that are missing.

@lrljoe
Copy link
Collaborator Author

lrljoe commented Feb 9, 2025

This PR migrates majority of pills into an AlpineJS function.

To-Do prior to release is:

  • Some native handling of additional events.
  • Adding some missing tests

@lrljoe lrljoe merged commit 203d7ad into rappasoft:development Feb 9, 2025
@lrljoe lrljoe mentioned this pull request Feb 27, 2025
9 tasks
lrljoe added a commit that referenced this pull request Feb 28, 2025
## [v3.7.0] - 2025-02-27

### Bug Fixes
- Filters urgent fixes - correct Filter Default QueryString by @lrljoe in #2188
- Fix Search Field in bootstrap by @yparitcher in #2183
- Add "after-tools" configurable area by @lrljoe in #2180

### New Features
- Add setFilterPillTitleAsHtml by @lrljoe in #2204
- Enable setting styles for sorting pills as a configuration by @HussamAlhennawi in #2179
- Enable setting styles for filter pills as a configuration by @HussamAlhennawi in #2178
- Enable setting styles for column select as a configuration by @HussamAlhennawi in #2175
- BulkActionTweaks - Adding default checkbox, customising attribute behaviours by @lrljoe in #2203
- Laravel v12 Support by @lrljoe in #2217

### Tweaks
- Tweak for text pill title by @lrljoe in #2206
- Tweak Return Types by @lrljoe in #2205
- Migrate Column/Filter Traits by @lrljoe in #2202
- Filter Rationalisation & Livewire Array Filter improvements by @lrljoe in #2191
- Move Filter View Traits by @lrljoe in #2189
- Filter Trait - Reorganization by @lrljoe in #2181
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant